svn commit: r184645 - head/usr.bin/vmstat

Giorgos Keramidas keramida at freebsd.org
Tue Nov 4 18:31:55 PST 2008


On Tue, 4 Nov 2008 23:16:39 +0100, "Ivan Voras" <ivoras at gmail.com> wrote:
> 2008/11/4 Diomidis Spinellis <dds at aueb.gr>:
>> On Nov 4, 2008, at 8:02 PM, Giorgos Keramidas wrote:
>>
>>> Author: keramida (doc committer)
>>> Date: Tue Nov  4 18:02:35 2008
>>> New Revision: 184645
>>> URL: http://svn.freebsd.org/changeset/base/184645
>>>
>>> Log:
>>>  Repeat vmstat header after window.rows instead of a hardcoded 20.
>
>> Thanks!  This functionality is generally useful and tricky to code in a
>> correct way.
>
> Any objections to
>
> http://people.freebsd.org/~ivoras/diffs/vmstat.c.patch.txt ?
>
> It uses humanize_number on interrupt, syscall and context switch counts.

It's great!  I'm only a bit worried about breaking many people's scripts
if we change the format to include humanized numbers by default, so I
would like to see a similar patch committed but disabled by default for
a while (and enabled by a command-line option like `-h').

The `-h' option seems to be the BSD equivalent of what GNU people would
call `--humanized-output'.  It would be nice to have vmstat and iostat
display humanized numbers but let's keep the default to its traditional
style and make the new output style accessible too :)



More information about the svn-src-all mailing list