svn commit: r185893 - head/sys/kern

[Bjoern A. Zeeb]

On Wed, 10 Dec 2008, Bjoern A. Zeeb wrote:

> Author: bz
> Date: Wed Dec 10 22:17:09 2008
> New Revision: 185893
> URL: http://svn.freebsd.org/changeset/base/185893
>
> Log:
>  Make sure nmbclusters are initialized before maxsockets
>  by running the tunable_mbinit() SYSINIT at SI_ORDER_MIDDLE
>  before the init_maxsockets() SYSINT at SI_ORDER_ANY.
>
>  Reviewed by:		rwatson, zec
>  Sponsored by:		The FreeBSD Foundation
>  MFC after:		4 weeks

The problem was found by Marko Zec during the preparation of the next
vimage commit patch. Booting different kernels (w/ and w/o the patch)
resulted in different values for net.inet.tcp.maxtcptw and
kern.ipc.maxsockets.

After careful review it was clear that the intialization values for
all relevant variables had not been altered.

Further debugging revealed that the order the SYSINITs were run had
changed.

This has been around for quite a while and worked more or less out of
linker luck.

/bz

-- 
Bjoern A. Zeeb                      The greatest risk is not taking one.