svn commit: r569288 - head/devel/bitkeeper

[Baptiste Daroussin]

On Fri, Mar 26, 2021 at 09:41:06PM -0700, Cy Schubert wrote:
> In message <20210327040518.GA30283 at FreeBSD.org>, Alexey Dokuchaev writes:
> > On Sat, Mar 27, 2021 at 02:45:05AM +0000, Cy Schubert wrote:
> > > New Revision: 569288
> > > URL: https://svnweb.freebsd.org/changeset/ports/569288
> > > 
> > > Log:
> > >   devel/bitkeeper: pet portlint: compress man pages
> > >   
> > >   Compress man pages satisfying portlint.
> >
> > Well, no, we compress manpages to satisfy common sense and save some
> > disk space. :-)
> >
> > > ...
> > > -	${MAKE_CMD} DESTDIR=${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARGET})
> > > +	${MAKE_CMD} DESTDIR=${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_TARGET}); 
> > \
> > > +	${GZIP_CMD} ${STAGEDIR}${PREFIX}/bitkeeper/man/man1/*
> > > +
> > > 
> > >  .include <bsd.port.mk>
> >
> > Why not amend MANDIRS to include custom manpage directory so that the
> > standard `compress-man' from b.p.m could do its work?  Also, you've
> > inserted superfluous linefeed there.
> 
> I forgot about that, thanks. I used MANPREFIX instead.
> 

MANDIRS is the right thing to use, MANPREFIX is not support to be overwritten
and only works by accident here.

MANDIRS is the list of directories where we expect to lookup for manpages to
compress them.

Second if you do install manpages in unusual location, it is expected that you
add this location into manpath for the users to be able to actually access those
manpages.

Somehow many ports seems to forget to do it. A good example of what to do here
is shown by the perl port which adds a perl5.conf to ETCDIR/man.d (so does npm)

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20210327/630b9d0a/attachment.sig>