svn commit: r569233 - head/lang/ghc

[Danilo G. Baio]

On Fri, Mar 26, 2021 at 11:06:32AM +0300, Gleb Popov wrote:
> On Fri, Mar 26, 2021 at 3:44 AM Danilo G. Baio <dbaio at freebsd.org> wrote:
> 
> > Author: dbaio
> > Date: Fri Mar 26 00:44:39 2021
> > New Revision: 569233
> > URL: https://svnweb.freebsd.org/changeset/ports/569233
> >
> > Log:
> >   lang/ghc: Generate PORTDOCS pkg-plist dynamically
> >
> >   This is the best approach for ports building its documentation with
> > Sphinx in
> >   html and will save time on future Sphinx updates.
> >
> >   Approved by:  portmgr blanket
> >
> > Modified:
> >   head/lang/ghc/Makefile
> >   head/lang/ghc/pkg-plist
> >
> > Modified: head/lang/ghc/Makefile
> >
> > ==============================================================================
> > --- head/lang/ghc/Makefile      Fri Mar 26 00:40:44 2021        (r569232)
> > +++ head/lang/ghc/Makefile      Fri Mar 26 00:44:39 2021        (r569233)
> > @@ -84,6 +84,8 @@ BOOT_LLVM_VERSION=    90
> >
> >  PLIST_SUB=             GHC_VERSION=${GHC_VERSION}
> > CABAL_VERSION=${CABAL_VERSION}
> >
> > +PORTDOCS=              *
> > +
> >  .include <bsd.port.pre.mk>
> >
> >  # This version of ncurses is needed by bootstrap compiler
> >
> 
> I spent quite a time to make the pkg-plist fully static, and now you make
> such a change without consulting the port's maintainer.
> 
> I was thinking that static pkg-plist's are generally favored over
> dynamically-generated ones. Why usual "make makeplist" didn't work for you?
> Why didn't you ask me to help you with Sphinx upgrade?


Note that this is not a plist recommendation in general, just for
documentation html and Sphinx.

I've been doing this kind of changes since I started maintaining Sphinx
and it's becoming easier to maintain/update Sphinx and all ports that
use it over time.

In this case there was an issue reported on Twitter, lang/ghc wasn't
building with the older Sphinx, I think this kind of issue isn't nice
because the port clearly works with both versions (yes I could set a
Sphinx version >= 3.5.2), but this is a ports/plist/sphinx issue.

The improvement here was tested on my set of poudriere jails with all
options enabled, all options disabled, mixed values on Sphinx 3.5.2 and
3.4.3, I consider this an improvement for lang/ghc, which was made in
others important ports as well.

In the future, I'll surely ask for your help, thank you.

Regards.
-- 
Danilo G. Baio (dbaio)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20210326/91fc991e/attachment.sig>