svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files

[Mathieu Arnold]

On Tue, Mar 16, 2021 at 08:59:29PM +0100, Adriaan de Groot wrote:
> On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote:
> > On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote:
> > > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> > > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > > > > -	@${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > > > > +	# Drop all leading spaces in the script, to minify
> > > > > +	@${REINPLACE_CMD} 's/^  *//' ${PKGINSTALL} ${PKGDEINSTALL}
> > > > 
> > > > [[:space:]] works with all versions.
> > > 
> > > Yes please.  Not just it's more robust, it also expresses the intention
> > > better, as we probably want to trim *any* unnecessary whitespace, not
> > > some particular character.
> > 
> > So, anything prevents us from going the [[:blank:]] way?
> 
> So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to prod 
> at this right now.

From isspace(3) :

“\t”   “\n”    “\v”    “\f”    “\r”    “ ”

from isblank(3) :

“\t”   “ ”


-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20210316/48b31cd5/attachment.sig>