svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files

Alexey Dokuchaev danfe at freebsd.org
Tue Mar 16 02:19:09 UTC 2021


On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote:
> On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > > -	@${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > > +	# Drop all leading spaces in the script, to minify
> > > +	@${REINPLACE_CMD} 's/^  *//' ${PKGINSTALL} ${PKGDEINSTALL}
> > 
> > [[:space:]] works with all versions.
> 
> Yes please.  Not just it's more robust, it also expresses the intention
> better, as we probably want to trim *any* unnecessary whitespace, not
> some particular character.

So, anything prevents us from going the [[:blank:]] way?

./danfe


More information about the svn-ports-head mailing list