svn commit: r550187 - head/multimedia/libass

[Jan Beich]

Thomas Zander <riggs at freebsd.org> writes:

> On Sat, 26 Sep 2020 at 16:39, Jan Beich <jbeich at freebsd.org> wrote:
>> > -USE_GITHUB=  yes
>> > -
>> > -USES=                autoreconf iconv libtool pathfix pkgconfig
>> > +USES=                autoreconf iconv libtool pathfix pkgconfig tar:xz
>>
>> Why did you keep USES=autoreconf given pre-generated configure script in the new distfile?
>
> I hit compilation issues with the pre-generated configure script during testing.
> Since we had no problem with the non-release-tarball generating
> configure, I opted to continue using autoreconf for now.

I can't reproduce, see attached patch and build log.

If you're not using pre-generated build files there's no point switching
from USE_GITHUB. Maybe look at the PHB chapter referenced in bug 249502
to understand "suggest" can just as well be "faulty generalization".

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libass.no-autoreconf.diff
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200926/3d923dfd/attachment-0002.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: libass-0.14.0.log
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200926/3d923dfd/attachment-0003.ksh>