svn commit: r553559 - in head/x11: . tilix

[Romain Tartière]

On Wed, Oct 28, 2020 at 09:00:39PM +0100, Jan Beich wrote:
> Romain Tartière <romain at FreeBSD.org> writes:
> 
> > +PATCH_DIST_STRIP=-p1
> > +PATCH_SITES=	https://patch-diff.githubusercontent.com/raw/gnunn1/tilix/pull/
> > +PATCHFILES=	1733.diff
> 
> pull/1234.diff is a moving target. Better use commit hashes e.g.,
> 
> PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
> PATCHFILES+=	ce11b0bd936f.patch:-p1 # https://github.com/gnunn1/tilix/pull/1733

Good catch, this indeed makes sense!

> > +BUILD_DEPENDS=	ldc2:lang/ldc \
> > +		po4a-translate:textproc/po4a \
> > +		${LOCALBASE}/libdata/pkgconfig/vted-3.pc:x11-toolkits/gtkd
> 
> Why not use shared libs like Alpine, Arch, Debian, Fedora, Void?
> See https://github.com/DankBSD/ports/commit/2b892e4ea4aa

Oh, I was not aware of this effort :-( !  I hapenned to find out some
old WIP ports in my local ports directory, and saw that I could get
everything to compile, so as these pieces where not in the FreeBSD ports
tree I though it was worth it to push them…

Building shared libs seems to require quite a lot of extra work but the
author of these ports seems to have done all this.  I added him in Cc
(hey Greg!).  Is there a reason for your ports x11-toolkits/gtkd-3 and
x11/tilix _not_ being in the "official" FreeBSD ports tree?  Do you have
something to share regarding this point Jan made?  Should we not
better integrate _your_ ports in the FreeBSD ports tree and replace what
I just committed?  Would you be interested in being the maintainer of
these ports?  I am very sorry to reach you only now and would have been
ways happier to be able to contact you before for talking about this!

Thanks,
Romain

-- 
Romain Tartière <romain at blogreen.org>        http://romain.blogreen.org/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20201028/fc1abd89/attachment.sig>