svn commit: r533992 - head/sysutils/xe-guest-utilities

[Baptiste Daroussin]

On Mon, May 04, 2020 at 09:46:48PM +0000, Dirk Meyer wrote:
> Author: dinoex
> Date: Mon May  4 21:46:47 2020
> New Revision: 533992
> URL: https://svnweb.freebsd.org/changeset/ports/533992
> 
> Log:
>   - make RUN_DEPENDS more robust
> 
> Modified:
>   head/sysutils/xe-guest-utilities/Makefile
> 
> Modified: head/sysutils/xe-guest-utilities/Makefile
> ==============================================================================
> --- head/sysutils/xe-guest-utilities/Makefile	Mon May  4 21:45:08 2020	(r533991)
> +++ head/sysutils/xe-guest-utilities/Makefile	Mon May  4 21:46:47 2020	(r533992)
> @@ -11,7 +11,7 @@ DISTNAME=	${PORTNAME}-6.0.2
>  MAINTAINER=	dinoex at FreeBSD.org
>  COMMENT=	FreeBSD VM tools for Citrix XenServer and XCP
>  
> -RUN_DEPENDS=	xen-guest-tools>0:${PKGCATEGORY}/xen-guest-tools
> +RUN_DEPENDS=	${LOCALBASE}/bin/xenstore:${PKGCATEGORY}/xen-guest-tools

how it is more robust?
1 finding a package (previous code) or finding the binary second code is both as
robust.

second I don't understand why you added the full path and not just xenstore:...

Last one should really directly write the origin of a package and not use a
variable that may changes, so ${PKGCATEGORY} both in new and old code at least
weird here.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200505/dae815fa/attachment.sig>