svn commit: r546857 - in head/www: . gallery-dl

Jan Beich jbeich at FreeBSD.org
Mon Aug 31 17:37:00 UTC 2020


Mathieu Arnold <mat at freebsd.org> writes:

> On Sat, Aug 29, 2020 at 12:38:28AM +0000, Jan Beich wrote:
>
>> +post-build:
>> +# USE_GITHUB archive doesn't have generated files
>> +	@${DO_MAKE_BUILD} -C ${BUILD_WRKSRC} PYTHON="${PYTHON_CMD}" man completion
>
> As the author also provides a working tarball, why use the incomplete github archive?
>
> https://github.com/mikf/gallery-dl/releases/download/v1.14.5/gallery_dl-1.14.5.tar.gz

Easier to test snapshots or apply upstream fixes and better reproducibility.

One could drop USE_PYTHON=distutils and build via make(1) a la www/youtube_dl
but I didn't like it because calling setup.py manually is error-prone.
For example, www/youtube_dl doesn't precompile *.py files.


More information about the svn-ports-head mailing list