svn commit: r544720 - head/sysutils/openzfs-kmod

[Kyle Evans]

On Wed, Aug 12, 2020 at 8:09 AM Alan Somers <asomers at freebsd.org> wrote:
>
> On Wed, Aug 12, 2020 at 6:54 AM Kyle Evans <kevans at freebsd.org> wrote:
>>
>> On Tue, Aug 11, 2020 at 5:25 PM Alan Somers <asomers at freebsd.org> wrote:
>> >
>> > Author: asomers (src committer)
>> > Date: Tue Aug 11 22:25:20 2020
>> > New Revision: 544720
>> > URL: https://svnweb.freebsd.org/changeset/ports/544720
>> >
>> > Log:
>> >   sysutils/openzfs-kmod: fix the build with a nonstandard SRC_BASE
>> >
>> >   ports that need FreeBSD's src code should check $SRC_BASE rather than assume
>> >   /usr/src. For example, it should be possible to build openzfs-kmod with a
>> >   command like this:
>> >
>> >   env SRC_BASE=$HOME/freebsd/base/head make
>> >
>> >   Approved by:  freqlabs (maintainer)
>> >   MFH:          2020Q3
>> >   Sponsored by: Axcient
>> >   Differential Revision:        https://reviews.freebsd.org/D26033
>> >
>>
>> For future reference, this actually needed additional approval for the
>> commit to ports, since neither you nor freqlabs are ports committers.
>> This commit looks fine to me and I don't reckon you need to do
>> anything with this information for now, though.
>>
>> Thanks,
>>
>> Kyle Evans
>
>
> Sorry.  brd previously told me that maintainer approval was sufficient for changes like this.
> -Alan

Ah, ok, so this makes sense- to clarify, this statement is true if
it's qualified with 'assuming the maintainer is a ports committer'.
You wouldn't need to seek out a second ports committer if the
maintainer is already one and approves of the change.