svn commit: r515252 - head/x11/cool-retro-term

[Tobias Kortkamp]

On Wed, Oct 23, 2019 at 12:50:11PM +0000, Alexey Dokuchaev wrote:
> On Wed, Oct 23, 2019 at 02:43:02PM +0200, Tobias Kortkamp wrote:
> > On Wed, Oct 23, 2019 at 12:11:24PM +0000, Alexey Dokuchaev wrote:
> > > New Revision: 515252
> > > URL: https://svnweb.freebsd.org/changeset/ports/515252
> > > 
> > > Log:
> > >   - Switch to USES+=compiler:c++11-lang to unbreak on PowerPC instead
> > >     of the approach taken in r513793 (Clang was never required for this
> > >     port, any not-so-ancient compiler would suffice)
> > >   - Sort the values on the USES list; avoid hardcoding version numbers
> > > [...]
> > > @@ -16,24 +16,15 @@ GH_ACCOUNT=	Swordfish90
> > >  GH_PROJECT=	qmltermwidget:qtw
> > >  GH_TAGNAME=	0.2.0:qtw
> > > [...]
> > >  post-extract:
> > >  	@${RMDIR} ${WRKSRC}/qmltermwidget
> > > -	@${LN} -s ../qmltermwidget-0.2.0 ${WRKSRC}/qmltermwidget
> > > +	@${LN} -s ../qmltermwidget-${GH_TAGNAME_qtw} ${WRKSRC}/qmltermwidget
> > 
> > This is very complicated
> 
> Not true. :)
> 
> > and unnecessary.
> 
> That's true.
> 
> > post-extract should be removed and replaced with
> > GH_SUBDIR=	qmltermwidget:qtw
> 
> Yeah, I know; AFAIR I've ported this before we had multi-repo (external
> references) support in the framework and never converted.

Sure, but you might as well modernize the port since you are touching
it (and post-extract) now.

> I can do that if you insist.

Yes, I insist.  Thank you in advance.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191023/ef0b72a9/attachment.sig>