svn commit: r513663 - head/www/py-lektor

[Vinícius Zavam]

adding to my TODO here. thanks!

Am Fr., 4. Okt. 2019 um 02:30 Uhr schrieb Kubilay Kocak <koobs at freebsd.org>:

> On 3/10/2019 10:50 pm, Vinícius Zavam wrote:
> > Author: egypcio
> > Date: Thu Oct  3 12:50:38 2019
> > New Revision: 513663
> > URL: https://svnweb.freebsd.org/changeset/ports/513663
> >
> > Log:
> >    www/py-lektor: add devel/py-pip to RUN_DEPENDS
> >
> >      - Makefile
> >        based on upstream's setup.py, adding 'pip' to RUN_DEPENDS;
> >        without 'pip' the lektor application wouldn't work as expected.
> >
> >    https://github.com/lektor/lektor/blob/3.1.3/setup.py
> >
> > Modified:
> >    head/www/py-lektor/Makefile
> >
> > Modified: head/www/py-lektor/Makefile
> >
> ==============================================================================
> > --- head/www/py-lektor/Makefile       Thu Oct  3 11:18:02 2019
> (r513662)
> > +++ head/www/py-lektor/Makefile       Thu Oct  3 12:50:38 2019
> (r513663)
> > @@ -2,6 +2,7 @@
> >
> >   PORTNAME=   Lektor
> >   PORTVERSION=        3.1.3
> > +PORTREVISION=        1
> >   CATEGORIES= www devel python
> >   MASTER_SITES=       CHEESESHOP
> >   PKGNAMEPREFIX=      ${PYTHON_PKGNAMEPREFIX}
> > @@ -20,7 +21,8 @@ RUN_DEPENDS=
> ${PYTHON_PKGNAMEPREFIX}Jinja2>=2.4:devel/
> >               ${PYTHON_PKGNAMEPREFIX}Babel>=0:devel/py-babel@${PY_FLAVOR}
> \
> >               ${PYTHON_PKGNAMEPREFIX}setuptools>=0:devel/py-setuptools@${PY_FLAVOR}
> \
> >               ${PYTHON_PKGNAMEPREFIX}requests>=0:www/py-requests@${PY_FLAVOR}
> \
> > -             ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@
> ${PY_FLAVOR}
> > +             ${PYTHON_PKGNAMEPREFIX}inifile>=0.4:devel/py-inifile@${PY_FLAVOR}
> \
> > +             ${PYTHON_PKGNAMEPREFIX}pip>=0:devel/py-pip@${PY_FLAVOR}
> >
> >   USES=               python
> >   USE_PYTHON= autoplist distutils
> >
>
> The only place pip is used is in WRKSRC/lektor/packages.py
>
> def download_and_install_package
> def install_local_package
>
> And pip should not be used to install dependencies
>
> pip should be removed from (patched out of) from install_requires and
> *_requires (extras_require, etc) used instead to describe
> additional/extra/non-compulsory dependencies)
>
> This should be sent/fixed upstream.
>