svn commit: r514356 - in head/shells: . elvish

[Tobias Kortkamp]

On Sat, Oct 12, 2019 at 06:12:36PM +0000, Rodrigo Osorio wrote:
> Author: rodrigo
> Date: Sat Oct 12 18:12:36 2019
> New Revision: 514349
> URL: https://svnweb.freebsd.org/changeset/ports/514349
> 
> Log:
>   New ports sysutils/sanoid and sysutils/sanoid-devel
>   
>   Sanoid is a policy-driven snapshot management tool
>   for ZFS filesystems. You can use Sanoid to create,
>   automatically and monitor snapshots.
>   
>   Add sysutils/sanoid-devel to track interesting
>   moments on the master branch.
>   
>   PR:		238584
>   Submitted by:	<hartzell at alerce.com>
>
> Added: head/sysutils/sanoid-devel/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/sanoid-devel/Makefile	Sat Oct 12 18:12:36 2019	(r514349)
> @@ -0,0 +1,51 @@
> +# $FreeBSD$
> +
> +PORTNAME=	sanoid
> +PORTVERSION=1.0.0.20190619
> +CATEGORIES=	sysutils
> +PKGNAMESUFFIX=-devel
> +
> +MAINTAINER=	hartzell at alerce.com
> +COMMENT=	Policy-driven snapshot management and replication tools
> +
> +LICENSE=	GPLv3
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +RUN_DEPENDS=	${LOCALBASE}/bin/lzop:archivers/lzop \
> +		${LOCALBASE}/bin/mbuffer:misc/mbuffer \
> +		${LOCALBASE}/bin/pv:sysutils/pv \
> +		p5-Capture-Tiny>=0:devel/p5-Capture-Tiny \
> +		p5-Config-IniFiles>=0:devel/p5-Config-IniFiles
> +
> +USES=		shebangfix perl5
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	jimsalterjrs
> +GH_PROJECT=sanoid

Redundant.  GH_PROJECT is set to ${PORTNAME} by default.

> +GH_TAGNAME=a90eec3
> +
> +USE_PERL5=	run
> +SHEBANG_FILES=	findoid sanoid sleepymutex syncoid
> +
> +# line 19:  my %args = ("configdir" => "/etc/sanoid");
> +post-patch:
> +	@${REINPLACE_CMD} -i '' -e 's|/etc/sanoid|${PREFIX}/etc/sanoid|' \
> +		${WRKSRC}/sanoid
> +	@${REINPLACE_CMD} -i '' \
> +		-e 's|:/bin:/usr/bin:/sbin|:${PREFIX}/bin:/bin:/usr/bin:/sbin|' \
> +		${WRKSRC}/syncoid
> +
> +do-build:

If the port does not build anything this should be

NO_BUILD=	yes

From the looks of it, we could probably also add

NO_ARCH=	yes

> +
> +do-install:
> +	${INSTALL_SCRIPT} ${WRKSRC}/findoid ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_SCRIPT} ${WRKSRC}/sanoid ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_SCRIPT} ${WRKSRC}/sleepymutex ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_SCRIPT} ${WRKSRC}/syncoid ${STAGEDIR}${PREFIX}/bin
> +	@${MKDIR} ${STAGEDIR}/${ETCDIR}
> +	${INSTALL_DATA} ${WRKSRC}/sanoid.defaults.conf \
> +		${STAGEDIR}${ETCDIR}/sanoid.defaults.conf
> +	${INSTALL_DATA} ${WRKSRC}/sanoid.conf \
> +		${STAGEDIR}${ETCDIR}/sanoid.conf.sample
> +
> +.include <bsd.port.mk>
> 
> Added: head/sysutils/sanoid-devel/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/sanoid-devel/distinfo	Sat Oct 12 18:12:36 2019	(r514349)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1560978182
> +SHA256 (jimsalterjrs-sanoid-1.0.0.20190619-a90eec3_GH0.tar.gz) = 32fe6ef68735e074f8c11d28e06d4e4d9f35cde7b80bacb20636f0fb1fb45500
> +SIZE (jimsalterjrs-sanoid-1.0.0.20190619-a90eec3_GH0.tar.gz) = 113654
> 
> Added: head/sysutils/sanoid-devel/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/sanoid-devel/pkg-descr	Sat Oct 12 18:12:36 2019	(r514349)
> @@ -0,0 +1,4 @@
> +Sanoid is a policy-driven snapshot management tool for ZFS
> +filesystems.  More prosaically, you can use Sanoid to create,
> +automatically thin, and monitor snapshots and pool health from a
> +single eminently human-readable TOML config file.

Missing WWW here.

> 
> Added: head/sysutils/sanoid-devel/pkg-message
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/sanoid-devel/pkg-message	Sat Oct 12 18:12:36 2019	(r514349)
> @@ -0,0 +1,28 @@
> +[
> +{
> +  message: <<EOD
> +***************************************************************************
> +
> + Sanoid requires additional configuration in the ${PREFIX}/etc/sanoid.conf 
> + file.
> +
> + A sample has been installed in ${PREFIX}/etc/sanoid.conf.sample and

Wrong path to sanoid.conf.  It is installed under
/usr/local/etc/sanoid/sanoid.conf.

> + additional documentation can be found at the sanoid master site:
> + 
> +   https://github.com/jimsalterjrs/sanoid

This is probably missing a 'type: install'.  I do not think this
message needs to be displayed on upgrades again.

The homepage should be in pkg-descr too.

> +
> +***************************************************************************
> +EOD
> +}
> +{
> +  message: <<EOD
> +***************************************************************************
> +
> + If you have created a local configuration file,
> + ${PREFIX}/etc/sanoid.conf, you will need to remove it separately.
> +
> +***************************************************************************
> +EOD
> +  type: remove
> +}
> +]

Redundant.  @sample already prints a message like this on deinstall
but only when sanoid.conf has been modified.

Please remove the noisy '****' banners.  They do not add anything
of value.

> Added: head/sysutils/sanoid/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/sysutils/sanoid/Makefile	Sat Oct 12 18:12:36 2019	(r514349)
> @@ -0,0 +1,51 @@
> +# $FreeBSD$
> +
> +PORTNAME=	sanoid
> +DISTVERSION=	v2.0.1
> +CATEGORIES=	sysutils

Should probably be

DISTVERSIONPREFIX=	v
DISTVERSION=	2.0.1

> +post-patch:
> [...]
> +	@${REINPLACE_CMD} -i '' \
> +		-e 's|/usr/bin/lzop|${PREFIX}/bin/lzop|' \
> +		-e 's|/usr/bin/mbuffer|${PREFIX}/bin/mbuffer|' \
> +		-e 's|/usr/bin/pv|${PREFIX}/bin/pv|' \
> +		-e 's|/usr/bin/sudo|${PREFIX}/bin/sudo|' \
> +		${WRKSRC}/syncoid

Dependencies come from LOCALBASE.  This should use LOCALBASE not
PREFIX.

Most of the other items from sanoid-devel also apply to sanoid.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191013/b47839bd/attachment.sig>