svn commit: r513618 - head/devel/scons

[Tijl Coosemans]

On Mon, 7 Oct 2019 10:29:34 +0200 Mathieu Arnold <mat at FreeBSD.org> wrote:
> On Sun, Oct 06, 2019 at 06:02:48PM +0200, Tijl Coosemans wrote:
>> On Wed, 2 Oct 2019 19:51:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh
>> <sunpoet at FreeBSD.org> wrote:  
>>> Author: sunpoet
>>> Date: Wed Oct  2 19:51:04 2019
>>> New Revision: 513618
>>> URL: https://svnweb.freebsd.org/changeset/ports/513618
>>> 
>>> Log:
>>>   Update to 3.1.1
>>>   
>>>   Changes:	https://scons.org/tag/releases.html
>>>   		https://github.com/SCons/scons/blob/master/src/CHANGES.txt
>>>   PR:		240584
>>>   Exp-run by:	antoine
>>> 
>>> Modified:
>>>   head/devel/scons/Makefile
>>>   head/devel/scons/distinfo
>>> 
>>> Modified: head/devel/scons/Makefile
>>> ==============================================================================
>>> --- head/devel/scons/Makefile	Wed Oct  2 19:50:04 2019	(r513617)
>>> +++ head/devel/scons/Makefile	Wed Oct  2 19:51:04 2019	(r513618)
>>> @@ -2,7 +2,7 @@
>>>  # $FreeBSD$
>>>  
>>>  PORTNAME=	scons
>>> -PORTVERSION=	3.0.1
>>> +PORTVERSION=	3.1.1
>>>  CATEGORIES=	devel python
>>>  MASTER_SITES=	SF
>>>  
>>> @@ -15,17 +15,16 @@ LICENSE_FILE=	${WRKSRC}/LICENSE.txt
>>>  RUN_DEPENDS=	gm4:devel/m4
>>>  
>>>  USES=		python:2.7 shebangfix
>>> -SHEBANG_FILES=	script/scons*
>>> -USE_PYTHON=	distutils autoplist
>>> +USE_PYTHON=	autoplist distutils  
>> 
>> It's probably a bug in portmaster but currently it always rebuilds
>> flavored ports (even if there isn't a new version) if the *_DEPENDS line
>> doesn't specify which flavor is needed.  Can you either add @py27 to the
>> BUILD_DEPENDS line in Mk/Uses/scons.mk or add USE_PYTHON=noflavors here?
>> If scons only supports one version of python I guess it doesn't need to
>> be flavored.  
> 
> I is a bug in portmaster. If the depends line does not specify the
> flavor, it means the default (first) flavor needs to be used, always.
> 
> I do not think adding shims in the ports tree to fix badly behaving
> third party tools is a very good idea, or sets a good precedent.

But the question remains, does this port need flavors?  Most ports that
install python scripts don't seem to be flavored.  devel/meson for
instance is a build system like scons and it has USE_PYTHON=noflavors.