svn commit: r513679 - head/sysutils/fusefs-smbnetfs/files

[Mathieu Arnold]

On Sun, Oct 06, 2019 at 11:07:42PM -0400, Mikhail T. wrote:
> On 06.10.19 04:11, Tobias Kortkamp wrote:
> > We do not have options specific PORTREVISIONs and there are more package
> > repositories than pkg.FreeBSD.org. If you have previously built your
> > packages with LIBSECRET=on, the applied fix will change the package in a
> > non-trivial way. However since PORTREVISION was not bumped Poudriere or
> > other package builders will not rebuild the package. Bascially people
> > will have to micromanage/force the rebuild fusefs-smbnetfs if they want
> > this fix. fusefs-smbnetfs is hardly an expensive package to build so
> > saving rebuilds at the cost of wasting people's time is not worth it and
> > bad UX.
> 
> What I'm trying to avoid is the opposite -- thousands of package-builders,
> tens of thousands of users, rebuilding their fusefs-smbnetfs for no reason
> whatsoever. /That/ is bad user experience...
> 
> Considering, that no one has contacted me about adding this particular patch
> -- despite it being available on SourceForge for months -- I suspect rather
> strongly, that it simply is not used with LIBSECRET by anyone... Or, if a
> few people are actually building it with the option turned on, that's a
> deliberate action and they are not trying to disable the feature through
> configuration -- which disabling is now fixed by the new patch.

The good thing is that it is not up to you to make up rules.  The rule,
clearly stated here
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision
states that:

  PORTREVISION must be increased each time a change is made to the port
  that changes the generated package in any way. That includes changes
  that only affect a package built with non-default options.

If something is not clear in that sentence, please tell me where and in
what way so that I can make it more clear to understand.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191007/cab34605/attachment.sig>