svn commit: r513844 - head/emulators/qemu

[Tobias Kortkamp]

On Sun, Oct 06, 2019 at 12:25:21PM +0600, Muhammad Moinur Rahman wrote:
> qemu has a slave port. So we are using USES?. But for qemu-utils or qemu-guest-agent we just need USES=xorg and nothing else. Adding USES=xorg doesn’t work.  :(

It seems I have been unclear.  USES?+= (note the extra +) does not
do what you want and is a nop.  It does not append to 'USES' but
it appends to 'USES?' which is not right at all.

$ make -C emulators/qemu -V 'USES?'
xorg

> > On 6 Oct, 2019, at 12:21, Tobias Kortkamp <tobik at freebsd.org> wrote:
> > 
> > On Sat, Oct 05, 2019 at 08:27:26PM +0000, Muhammad Moinur Rahman wrote:
> >> Author: bofh
> >> Date: Sat Oct  5 20:27:25 2019
> >> New Revision: 513844
> >> URL: https://svnweb.freebsd.org/changeset/ports/513844
> >> 
> >> Log:
> >>  emulators/qemu: Update version 3.1.1=>3.1.1.1
> >> 
> >> Modified:
> >>  head/emulators/qemu/Makefile
> >>  head/emulators/qemu/distinfo
> >> 
> >> Modified: head/emulators/qemu/Makefile
> >> ==============================================================================
> >> --- head/emulators/qemu/Makefile	Sat Oct  5 18:52:36 2019	(r513843)
> >> +++ head/emulators/qemu/Makefile	Sat Oct  5 20:27:25 2019	(r513844)
> >> @@ -2,7 +2,7 @@
> >> # $FreeBSD$
> >> 
> >> PORTNAME=	qemu
> >> -PORTVERSION=	3.1.1
> >> +PORTVERSION=	3.1.1.1
> >> CATEGORIES=	emulators
> >> MASTER_SITES=	https://download.qemu.org/
> >> DIST_SUBDIR=	qemu/${PORTVERSION}
> >> @@ -20,6 +20,7 @@ LIB_DEPENDS?=	libnettle.so:security/nettle \
> >> 
> >> .if !defined(PKGNAMESUFFIX) || (${PKGNAMESUFFIX} != "-utils" && ${PKGNAMESUFFIX} != "-guest-agent")
> >> ONLY_FOR_ARCHS=	amd64 i386 powerpc powerpc64
> >> +USES?+=		xorg
> > 
> > It is unfortunate that make(1) accepts this, but 'USES?+=' means
> > 'append to a variable called USES?' which is probably wrong.  What
> > did you mean here?  'USES?=', 'USES+=' or maybe it should be removed
> > again?  At the moment this does not really do anything.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20191006/400b5c23/attachment-0001.sig>