svn commit: r501032 - head/emulators/qemu-sbruno

[Kyle Evans]

On Wed, May 8, 2019 at 3:02 PM Jan Beich <jbeich at freebsd.org> wrote:
>
> Antoine Brodin <antoine at freebsd.org> writes:
>
> > On Wed, May 8, 2019 at 6:36 PM Jan Beich <jbeich at freebsd.org> wrote:
> >
> >>
> >> Jan Beich <jbeich at FreeBSD.org> writes:
> >>
> >> > Antoine Brodin <antoine at FreeBSD.org> writes:
> >> >
> >> >> Author: antoine
> >> >> Date: Wed May  8 16:24:42 2019
> >> >> New Revision: 501032
> >> >> URL: https://svnweb.freebsd.org/changeset/ports/501032
> >> >>
> >> >> Log:
> >> >>   Unbreak qemu-user-static at runtime
> >> >
> >> > Why? Wasn't r500819 enough? It was even confirmed in
> >> > https://github.com/seanbruno/qemu-bsd-user/issues/74#issuecomment-490337655
> >>
> >> Also, I've just checked /latest package for -CURRENT:
> >> - qemu-aarch64-static works fine
> >> - qemu-arm-static works fine
> >
> > With version 2.11.50.g20190318_1,  I had crashes with:
>
> How did you upgrade to 2.11.50.g20190318_1? Built manually, built
> via poudriere or fetched /latest package from pkg.freebsd.org?
> If you mean the package cluster *itself* then it uses qemu-user-static
> from a build before e.g.,
>
> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p500844_s347134/.data.json
> ended on 2019-05-08 02:39:29 UTC
> http://beefy8.nyi.freebsd.org/data/head-armv6-default/p500844_s347134/.data.json
> started on 2019-05-05 01:07:43 UTC
>
> As 2.11.50.g20190318_1 wasn't available at the time 2.11.50.g20190318 was used
> which resulted in head-armv6 failing at the initialization. Nothing was built.
>
> > - qemu-mips-static
> > - qemu-arm-static
> > - qemu-mips64-static
> >
> > Changing SSP_CFLAGS fixed at least qemu-mips64-static.
>
> qemu-mips64-static works fine here without overriding SSP_CFLAGS in
> emulators/qemu-user-static.
>
> Did you rebuild both glib20 *then* qemu-user-static after r500819?
> qemu-user-static uses *static* libraries, so it has to be rebuilt each
> time one of its BUILD_DEPENDS changes.
>
> During my testing SSP_CFLAGS in emulators/qemu-user-static had no effect
> unlike in devel/glib20.

Hi,

I did some digging, and both of these commits ultimately just paper
over the actual problem -- we end up hitting SSP failures more
consistently in our qemu-rebase-3.1 branch even with these applied. It
turns out you've just reduced the surface area that's affected, and
the source of the bug is discussed in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241905 -- once we
get that hammered out, we can/should revert both of these. This is
mostly just an FYI to help explain the differences in behavior, since
nothing can be done at this time from a ports' perspective.

Thanks,

Kyle Evans