svn commit: r504132 - head/security/vuxml

[Adam Weinberger]

On Sat, Jun 15, 2019 at 9:12 AM Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
> On Thu, Jun 13, 2019 at 06:41:56PM +0000, Adam Weinberger wrote:
> > New Revision: 504132
> > URL: https://svnweb.freebsd.org/changeset/ports/504132
> >
> > Log:
> >   Add entry for Vim/NeoVim arbitrary code execution
> >
> > Modified:
> >   head/security/vuxml/vuln.xml
>
> Do we package Vim/NeoVim with modelines enabled by default?
>
> I've seen people say that in some distributions, default packages were not
> affected because their maintainers deliberately disable modelines, e.g. in
> Debian from 2007:
>
>   * debian/runtime/debian.vim.in
>     - set 'nomodeline' by default since modelines have historically been a
>       source of security/resource vulnerabilities.  Users should have to
>       explicitly enable the option to assume the associated risks.
>
> Also, from Gentoo's /etc/vim/vimrc:
>
>     We don't allow modelines by default. See bug #14088 and bug #73715.
>     basis by adding "set modeline" to your ~/.vimrc file.
>
> This sounds like a good idea.  Actually, any similar feature that allows to
> execute something based on user input should be disabled by default, because
> these things are very hard to get right (unless you're Daniel Bernstein).

Their default packages ARE affected. If your car explodes in 6th gear,
you can't say your car isn't affected because it starts up in first.
Whether they're enabled or disabled by default, the package is still
vulnerable.

# Adam


-- 
Adam Weinberger
adamw at adamw.org // adamw at FreeBSD.org
https://www.adamw.org