svn commit: r507479 - in head/graphics/ogre3d: . files

[Jan Beich]

Oliver Lehmann <oliver at FreeBSD.org> writes:

> +BUILD_DEPENDS=	pkgconf:devel/pkgconf

Already set by USES=pkgconfig.

> +USE_SDL=	sdl sdl2

sdl12 and sdl20 have conflicting symbols, so both cannot be loaded in
the same runtime. According to "poudriere testport" shared library check
only the latter appears to be used.

> +CMAKE_ARGS+=	-DOGRE_BUILD_RENDERSYSTEM_GL3PLUS:BOOL=OFF \
> +		-DOGRE_BUILD_RENDERSYSTEM_GL:BOOL=OFF \
> +		-DOGRE_BUILD_RENDERSYSTEM_GLES2:BOOL=OFF \
> +		-DOGRE_BUILD_COMPONENT_PYTHON:BOOL=OFF \
> +		-DOGRE_BUILD_COMPONENT_JAVA:BOOL=OFF \
> +		-DOGRE_BUILD_COMPONENT_CSHARP:BOOL=OFF \
> +		-DOGRE_BUILD_PLUGIN_FREEIMAGE:BOOL=OFF \
> +		-DOGRE_BUILD_PLUGIN_EXRCODEC:BOOL=OFF \
> +		-DOGRE_CONFIG_ENABLE_ZIP:BOOL=ON \
> +		-DOGRE_INSTALL_DOCS:BOOL=OFF \
> +		-DOGRE_INSTALL_SAMPLES_SOURCE:BOOL=OFF

Why not convert these to CMAKE_OFF as well?

> +DOCS_BUILD_DEPENDS=	doxygen:devel/doxygen
> +DOCS_CMAKE_BOOL=	OGRE_INSTALL_DOCS

Maybe rename DOCS to DOXYGEN to allow users skip the dependency globally
via OPTIONS_UNSET+=DOXYGEN in /etc/make.conf.

> +OPENEXR_DESC=		Build EXR Codec plugin

Probably redundant. See Mk/bsd.options.desc.mk

> +OPENGL_DESC=		OpenGL support

Probably redundant. See Mk/bsd.options.desc.mk

> +OPENGL_LIB_DEPENDS=	libGL.so:graphics/mesa-libs

Convert to USES=gl + USE_GL=gl.

> +OPENGL_VARS=		USE_XORG+=sm ice

Why not OPENGL_USE=sm ice? _VARS usage here is improperly escaped,
turning "ice" into a separate variable.

> +PROFILE_DESC=		Enable internal profiling support

Probably redundant. See Mk/bsd.options.desc.mk

> +CSHARP_DESC=		Build Csharp bindings
> +CSHARP_CMAKE_BOOL=	OGRE_BUILD_COMPONENT_CSHARP
> +CSHARP_BUILD_DEPENDS=	swig3.0:devel/swig30

Maybe rename CSHARP to MONO for consistency with other ports.

> +JAVA_DESC=		Build java bindings

Probably redundant. See Mk/bsd.options.desc.mk

> +JAVA_CMAKE_BOOL=	OGRE_BUILD_COMPONENT_JAVA
> +JAVA_BUILD_DEPENDS=	swig3.0:devel/swig30
> +JAVA_VARS=		USE_JAVA=yes \

Why not JAVA_USE=JAVA=yes ?

> +			CMAKE_ARGS+=-DJAVA_HOME=${JAVA_HOME}

Why not JAVA_CMAKE_ON=-DJAVA_HOME=${JAVA_HOME} ? As JAVA_HOME is
exported via environ(7) and cmake-modules(7) picks it up the line
maybe redundant.

> +PYTHON_DESC=		Build python bindings

Probably redundant. See Mk/bsd.options.desc.mk

> +CXXFLAGS+=		-DNDEBUG -I${LOCALBASE}/include

- Maybe disable -DNDEBUG when debugging e.g., ${WITH_DEBUG:D:U-DNDEBUG}
- Maybe replace -I${LOCALBASE}/include with USES=localbase:ldflags

> +# BROKEN_aarch64=		does not compile: error: class member cannot be redeclared

Builds fine, see https://reviews.freebsd.org/P280