svn commit: r505640 - head/java/openjdk11

[Piotr Kubaj]

No, when powerpc64 works with clang (which will by the way happen this month in head), openjdk11 should still build, because USE_GCC=yes is in .if ${COMPILER_TYPE} == gcc block.

On 19-07-02 10:35:15, Baptiste Daroussin wrote:
>On Tue, Jul 02, 2019 at 08:26:08AM +0000, Alexey Dokuchaev wrote:
>> On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote:
>> > Why not use USES=compiler:c11 instead of setting manually USE_GCC=yes?
>>
>> Technically they're semantically not the same; while pulling C11-capable
>> compiler might fix the problem, you're still telling the reader that you're
>> pulling C11-capable compiler, while USE_GCC means that you want GCC, devoid
>> of particular reasons.
>>
>> In practice, compiler:c11 often used as compiler:modern.  I'd welcome this
>> spelling: it would actually make things more clear because now people often
>> abuse compiler:c11 or (even worse) compiler:c++11-lang for 98/99 code which
>> gcc-4.2 cannot eat, or because one of the dependencies requires new compiler
>> (majority of cases).
>>
>> ./danfe
>>
>> P.S.  Sorry for lack of context due to prior top-posting.
>>
>
>Actually the majority of addition of compiler:c11 are wrong (from the one I have
>been able to check) and a simple USE_CSTD=c99 would have fix the build with
>gcc-4.2. It would be really nice to stop blindy using compiler:c11 ;)
>
>actually USE_GCC in this case is wrong as well, because if one day powerpc64
>works with llvm/clang, then this will be broken. One has to identify what is
>really making it inconcompatible with gcc-4.2, without checking it should be
>mostly related to c++ (as the jvm is mostly written in c++) and if it is because
>it uses "modern" c++ then any of the compiler:c++* is supposed to be the proper
>thing to add.
>
>Best regards,
>Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190702/a02d9b12/attachment.sig>