svn commit: r505444 - head/sysutils/lsof

Alexey Dokuchaev danfe at freebsd.org
Mon Jul 1 07:34:50 UTC 2019


On Sun, Jun 30, 2019 at 07:15:30PM +0000, Larry Rosenman wrote:
> New Revision: 505444
> URL: https://svnweb.freebsd.org/changeset/ports/505444
> 
> Log:
>   sysutils/lsof: quiet portlint.

This is very bad commit message, it explains nothing.  Moreover,
appealing to portling(1), blindly lihe this, is usually bogus and
wrong.

> Modified: head/sysutils/lsof/Makefile
> @@ -31,7 +31,7 @@ CONFIGURE_ARGS=	-n freebsd
>  CONFIGURE_ENV=	LSOF_CC="${CC}" FREEBSD_SYS="${SRC_BASE}/sys"
>  
>  .if !exists(${SRC_BASE}/sys/kern/kern_lockf.c)
> -IGNORE=		requires kernel sources
> +IGNORE+=		requires kernel sources
>  .endif

That said, could you explain the scenario (like, what make(1) commands
and under what circumstances I must type) to demonstrate what was wrong
here before and how did your commit fix it?

./danfe


More information about the svn-ports-head mailing list