svn commit: r491675 - in head/comms/fldigi: . files

[Alexey Dokuchaev]

On Thu, Jan 31, 2019 at 08:37:32AM -0500, Diane Bruce wrote:
> On Thu, Jan 31, 2019 at 02:14:39AM +0000, Alexey Dokuchaev wrote:
> > ...
> > These two patches were essentially not changed and should have been
> > dropped from the commit batch to reduce repo churn and diff noise.
> 
> Tell that to the make makepatch maintainers please.

Well, no: makepatch would never (and it's not supposed to) be so smart
to detect/mitigate these things.  Evaluating a diff (and commit hygiene
in general) is committer's responsibility.

That said, I understand that worrying about diff S/N is not for everyone,
just want to point out that one can control it, and quite easily: simple
svn revert after svn diff/st is usually sufficient.

Clean diffs help the readers, make svn blame'ing and source archaeology
in general easier.

./danfe