svn commit: r491618 - in head/net: . timed

Jan Beich jbeich at FreeBSD.org
Wed Jan 30 11:09:59 UTC 2019


Stefan Esser <se at FreeBSD.org> writes:

> +		${INSTALL_DATA} ${WRKSRC}/rc.d/timed \
> +			${STAGEDIR}${PREFIX}/etc/rc.d/

${INSTALL_DATA} unlike ${INSTALL_SCRIPT} strips executable bit. Are you sure?

$ make install
$ service timed onestart
timed does not exist in /etc/rc.d or the local startup
directories (/usr/local/etc/rc.d), or is not executable

> + at mode 4555
> +sbin/timedc

Looks unsafe as something may append ${TMPPLIST}, inheriting setuid bit.
Consider adding @mode at the end or converting to @(,,4555) sbin/timedc


More information about the svn-ports-head mailing list