svn commit: r491246 - in head/graphics/simpleviewer: . files

[Mathieu Arnold]

On Sat, Jan 26, 2019 at 09:53:04AM +0100, Tobias Kortkamp wrote:
> On Sat, Jan 26, 2019 at 09:48:52AM +0100, Mathieu Arnold wrote:
> > On Sat, Jan 26, 2019 at 08:01:17AM +0000, Tobias Kortkamp wrote:
> > > Author: tobik
> > > Date: Sat Jan 26 08:01:17 2019
> > > New Revision: 491246
> > > URL: https://svnweb.freebsd.org/changeset/ports/491246
> > > 
> > > Log:
> > >   graphics/simpleviewer: Install config.example
> > >   
> > >   PR:		217497
> > >   Submitted by:	wjenkner at inode.at
> > > 
> > > Added:
> > >   head/graphics/simpleviewer/files/
> > >   head/graphics/simpleviewer/files/pkg-message.in   (contents, props changed)
> > > Modified:
> > >   head/graphics/simpleviewer/Makefile
> > > 
> > > Modified: head/graphics/simpleviewer/Makefile
> > > ==============================================================================
> > > --- head/graphics/simpleviewer/Makefile	Sat Jan 26 07:19:32 2019	(r491245)
> > > +++ head/graphics/simpleviewer/Makefile	Sat Jan 26 08:01:17 2019	(r491246)
> > > @@ -3,7 +3,7 @@
> > >  
> > >  PORTNAME=	simpleviewer
> > >  PORTVERSION=	2.92
> > > -PORTREVISION=	5
> > > +PORTREVISION=	6
> > >  CATEGORIES=	graphics
> > >  MASTER_SITES=	https://bitbucket.org/andreyu/simple-viewer-gl/get/
> > >  DISTNAME=	v${PORTVERSION}	# version tag, thus no embedded ${PORTNAME}
> > > @@ -32,8 +32,16 @@ USE_XORG=	ice sm x11 xcursor xext xinerama xrandr xxf8
> > >  WRKSRC=		${WRKDIR}/andreyu-simple-viewer-gl-b3bd8710e176
> > >  
> > >  PLIST_FILES=	bin/sviewgl
> > > +PORTEXAMPLES=	config.example
> > > +SUB_FILES=	pkg-message
> > 
> > Maybe it should be:
> > 
> > EXAMPLES_SUB_FILES=  pkg-message
> > 
> > because it only applies if you have the EXAMPLES option on.
> 
> "You can put default command line switches into a configuration file,"
> 
> also applies when the example config file is not installed.

But then the user is wondering where said file is :-)

> > 
> > >  
> > > +OPTIONS_DEFINE=	EXAMPLES
> > > +
> > >  do-install:
> > >  	${INSTALL_PROGRAM} ${WRKSRC}/sviewgl ${STAGEDIR}${PREFIX}/bin
> > > +
> > > +do-install-EXAMPLES-on:
> > > +	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> > > +	${INSTALL_DATA} ${WRKSRC}/config.example ${STAGEDIR}${EXAMPLESDIR}
> > >  
> > >  .include <bsd.port.mk>
> > > 
> > > Added: head/graphics/simpleviewer/files/pkg-message.in
> > > ==============================================================================
> > > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > > +++ head/graphics/simpleviewer/files/pkg-message.in	Sat Jan 26 08:01:17 2019	(r491246)
> > > @@ -0,0 +1,3 @@
> > > +You can put default command line switches into a configuration file,
> > > +please see %%EXAMPLESDIR%%/config.example
> > > +for how to do it.
> > 
> > -- 
> > Mathieu Arnold
> 
> 



-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190126/104d13f8/attachment.sig>