svn commit: r491058 - head/www/node8

[Bradley T. Hughes]

On 2019-01-24 05:51, Bradley T. Hughes wrote:
> On 2019-01-23 23:00, Mathieu Arnold wrote:
>> On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote:
>>> -
>>> -.include <bsd.port.options.mk>
>>> -
>>> -.if empty(PORT_OPTIONS:MBUNDLED_SSL)
>>> -
>>> -.if !empty(SSL_DEFAULT:Mlibressl*)
>>> -IGNORE=        cannot build node.js with LibreSSL. You must enable 
>>> BUNDLED_SSL
>>> -.endif
>>> -
>>> -.endif
>>
>> Mmmm, this is not equivalent, now, the port is always marked as BROKEN
>> if the op uses libressl* as their default SSL library, even if
>> BUNDLED_SSL is set.
>>
>> And I think the other changes to the other node* ports are also wrong
>> for the same reason.
> 
> Good point, I hadn't considered that. I will fix them now :)

Actually, after looking at it more, setting BUNDLED_SSL on any of the 
www/node* ports causes the port to skip USES+=ssl, which in turn ignores 
BROKEN_SSL.

So, this works as I had intended it; setting 
DEFAULT_VERSIONS+=ssl=something only matters when BUNDLED_SSL is off, 
and I have set the defaults such that BUNDLED_SSL is off for FreeBSD 
versions that have a compatible OpenSSL in base. Changing SSL_DEFAULT 
can have an impact on whether or not www/node* builds, but that is 
circumvented by setting BUNDLED_SSL.

Thank you for the feedback. I appreciate review and questions about 
what/how I've done. :)

-- 
Bradley T. Hughes
bhughes at freebsd.org