svn commit: r491058 - head/www/node8

[Mathieu Arnold]

On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote:
> Author: bhughes
> Date: Wed Jan 23 21:14:27 2019
> New Revision: 491058
> URL: https://svnweb.freebsd.org/changeset/ports/491058
> 
> Log:
>   www/node8: convert port to use BROKEN_SSL
>   
>   Sponsored by:	Miles AS
> 
> Modified:
>   head/www/node8/Makefile
> 
> Modified: head/www/node8/Makefile
> ==============================================================================
> --- head/www/node8/Makefile	Wed Jan 23 21:10:26 2019	(r491057)
> +++ head/www/node8/Makefile	Wed Jan 23 21:14:27 2019	(r491058)
> @@ -13,6 +13,8 @@ COMMENT=	V8 JavaScript for client and server (8.x LTS)
>  LICENSE=	MIT
>  LICENSE_FILE=	${WRKSRC}/LICENSE
>  
> +BROKEN_SSL=		libressl libressl-devel
> +BROKEN_SSL_REASON=	Node.js 8.x LTS requires OpenSSL >= 1.0.2 or the BUNDLED_SSL option enabled
>  ONLY_FOR_ARCHS=		aarch64 amd64 armv6 armv7 i386 powerpc64
>  
>  OPTIONS_DEFINE=	BUNDLED_SSL DOCS NLS DTRACE
> @@ -62,16 +64,6 @@ MAKE_ENV+=	CC.host=${CC} CXX.host=${CXX} LINK.host=${C
>  LIB_DEPENDS+=	libcares.so:dns/c-ares\
>  		libuv.so:devel/libuv \
>  		libnghttp2.so:www/libnghttp2
> -
> -.include <bsd.port.options.mk>
> -
> -.if empty(PORT_OPTIONS:MBUNDLED_SSL)
> -
> -.if !empty(SSL_DEFAULT:Mlibressl*)
> -IGNORE=		cannot build node.js with LibreSSL. You must enable BUNDLED_SSL
> -.endif
> -
> -.endif

Mmmm, this is not equivalent, now, the port is always marked as BROKEN
if the op uses libressl* as their default SSL library, even if
BUNDLED_SSL is set.

And I think the other changes to the other node* ports are also wrong
for the same reason.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190123/53b1876c/attachment.sig>