svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest

[Sean Bruno]

On 1/8/19 10:23 AM, Sean Bruno wrote:
> 
> 
> On 1/3/19 4:23 PM, Tobias Kortkamp wrote:
>>>
>>> On 1/3/19 2:54 PM, Tobias Kortkamp wrote:
>>>>> +USE_QT=		buildtools \
>>>> Does clementine-player, a music player, really need qt5-buildtools
>>>> at runtime or should this be buildtools_build instead?
>>>>
>>>>> +		concurrent \
>>>>> +		core \
>>>>>  		dbus \
>>>>>  		gui \
>>>>>  		imageformats \
>>>>> -		qmake_build \
>>>>>  		linguist_build \
>>>>> -		moc_build \
>>>>>  		network \
>>>>>  		opengl \
>>>>> -		qtestlib \
>>>>> -		rcc_build \
>>>>> +		qmake_build \
>>>>> +		testlib \
>>>> Same here.  Does it really need qt5-testlib at runtime?
>>>>
>>> Probably not?
>>>
>>> sean
>>>
>> So I guess they are not needed at runtime.  Will you change them
>> to build dependencies?
> 
> Yeah, I'll look at it today.  Thanks!
> 
> sean
> 


Something like this will solve this runtime/buildtime depend issue?
Obviously, I'll buildtime/runtime test it before commit.

Index: audio/clementine-player/Makefile
===================================================================
--- audio/clementine-player/Makefile	(revision 489727)
+++ audio/clementine-player/Makefile	(working copy)
@@ -41,7 +41,7 @@
 USE_GL=		gl glew glu
 USE_XORG=	x11

-USE_QT=		buildtools \
+USE_QT=		buildtools_build \
 		concurrent \
 		core \
 		dbus \
@@ -51,7 +51,7 @@
 		network \
 		opengl \
 		qmake_build \
-		testlib \
+		testlib_build \
 		sql \
 		widgets \
 		x11extras \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190108/fa93de0c/attachment.sig>