svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest

[Tobias Kortkamp]

On Thu, Jan 03, 2019 at 03:30:44PM -0700, Sean Bruno wrote:
> 
> 
> On 1/3/19 2:54 PM, Tobias Kortkamp wrote:
> >> +USE_QT=		buildtools \
> > Does clementine-player, a music player, really need qt5-buildtools
> > at runtime or should this be buildtools_build instead?
> > 
> >> +		concurrent \
> >> +		core \
> >>  		dbus \
> >>  		gui \
> >>  		imageformats \
> >> -		qmake_build \
> >>  		linguist_build \
> >> -		moc_build \
> >>  		network \
> >>  		opengl \
> >> -		qtestlib \
> >> -		rcc_build \
> >> +		qmake_build \
> >> +		testlib \
> > Same here.  Does it really need qt5-testlib at runtime?
> > 
> 
> Probably not?
> 
> sean
> 

So I guess they are not needed at runtime.  Will you change them
to build dependencies?

There is another more severe problem.  The version goes backwards,
so users will never receive this update.

$ pkg version -t 1.3.1.g20190103 1.3.1.441_7
<

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190104/3b1e923f/attachment.sig>