svn commit: r509948 - head/security/gnupg

[Kubilay Kocak]

On 27/08/2019 12:46 am, Adam Weinberger wrote:
>> On Aug 26, 2019, at 08:43, Kubilay Kocak <koobs at freebsd.org> wrote:
>>
>>> On 27/08/2019 12:41 am, Adam Weinberger wrote:
>>> Author: adamw
>>> Date: Mon Aug 26 14:41:22 2019
>>> New Revision: 509948
>>> URL: https://svnweb.freebsd.org/changeset/ports/509948
>>> Log:
>>>    gnupg: enable the WKS server
>>>       Cristoph Lukas asked me why the WKS server was disabled, and I have
>>>    no idea. It was added r462573, and that commit message and associated
>>>    bug report don't list why --disable-wks-tools was added. (Folks,
>>>    please use commit messages for writing, you know, messages.)
>>>       We've been installing the gpg-wks-server manpage, so this commit
>>>    enables the WKS server and installs the binary, and bumps PORTREVISION
>>>    for it.
>>
>> Seems like a great candidate for an OPTION (enabled by default) ?
> 
> I’m not opposed to it, but I’m also not sure it’s necessary. It brings in no new dependencies, and adds a negligible amount to the disk usage. I know very little about the keyserver; is it something that a significant proportion wouldn’t want installed?

I know our FreeBSD users/community can be very picky, and thinking of 
the clear 'client / server' aspects of gnupg use-cases, it just seemed 
obvious, or at least like it made sense to provide the option.

I know I'd like it, fwiw :)

> # Adam
> 
> 
> —
> Adam Weinberger
> adamw at adamw.org
> https://www.adamw.org
> 
>>
>>>    While here, sort the plist.
>>> Modified:
>>>    head/security/gnupg/Makefile
>>>    head/security/gnupg/pkg-plist
>>> Modified: head/security/gnupg/Makefile
>>> ==============================================================================
>>> --- head/security/gnupg/Makefile    Mon Aug 26 13:47:28 2019    (r509947)
>>> +++ head/security/gnupg/Makefile    Mon Aug 26 14:41:22 2019    (r509948)
>>> @@ -2,7 +2,7 @@
>>>     PORTNAME=    gnupg
>>>   PORTVERSION=    2.2.17
>>> -PORTREVISION=    1
>>> +PORTREVISION=    2
>>>   CATEGORIES=    security
>>>   MASTER_SITES=    GNUPG
>>>   @@ -28,8 +28,7 @@ USES=        compiler:c11 cpe gmake iconv pkgconfig readline
>>>   CONFLICTS=    gnupg-2.0.* dirmngr-[0-9]*
>>>   CPE_VENDOR=    gnupg
>>>   -CONFIGURE_ARGS=    --disable-ntbtls --disable-wks-tools \
>>> -        --enable-gpg-is-gpg2 --enable-symcryptrun
>>> +CONFIGURE_ARGS=    --disable-ntbtls --enable-gpg-is-gpg2 --enable-symcryptrun
>>>   GNU_CONFIGURE=    yes
>>>   INFO=        gnupg
>>>   TEST_TARGET=    check
>>> Modified: head/security/gnupg/pkg-plist
>>> ==============================================================================
>>> --- head/security/gnupg/pkg-plist    Mon Aug 26 13:47:28 2019    (r509947)
>>> +++ head/security/gnupg/pkg-plist    Mon Aug 26 14:41:22 2019    (r509948)
>>> @@ -1,10 +1,11 @@
>>> -bin/gpg-agent
>>>   bin/dirmngr
>>>   bin/dirmngr-client
>>> +bin/gpg-connect-agent
>>> +bin/gpg-agent
>>>   bin/gpgscm
>>>   bin/gpgsm
>>>   bin/gpgtar
>>> -bin/gpg-connect-agent
>>> +bin/gpg-wks-server
>>>   bin/kbxutil
>>>   %%SUID_GPG%%@(,,4555) bin/gpg2
>>>   %%NO_SUID_GPG%%bin/gpg2
>>