svn commit: r479028 - head/games/yadex

[Mathieu Arnold]

On Mon, Sep 17, 2018 at 03:36:34PM +0000, Alexey Dokuchaev wrote:
> On Thu, Sep 06, 2018 at 01:30:03PM +0000, Alexey Dokuchaev wrote:
> > On Wed, Sep 05, 2018 at 11:49:47PM +0200, Mathieu Arnold wrote:
> > > On Wed, Sep 05, 2018 at 04:31:39PM +0000, Alexey Dokuchaev wrote:
> > > > New Revision: 479028
> > > > URL: https://svnweb.freebsd.org/changeset/ports/479028
> > > > 
> > > > Log:
> > > >   Consummate conversion to option helpers (should've been part of
> > > >   r479022).
> > > > 
> > > > Modified: head/games/yadex/Makefile
> > > > @@ -37,17 +37,10 @@ PATCH_SUFFIX=	.diff
> > > >  PATCHFILES=	${PATCH_PREFIX}_Depend${PATCH_SUFFIX}
> > > >  
> > > >  3D_RENDER_PATCHFILES=	${PATCH_PREFIX}_Render3D${PATCH_SUFFIX}
> > > > +3D_RENDER_PORTDOCS=	preview.html
> > > 
> > > This is missing a 3D_RENDER_IMPLIES=DOCS.
> > 
> > I don't think so, why?  One of the nice things about PORTDOCS that is can
> > (and should) be set unconditionally (independent of DOCS).  In fact, I
> > could have simply got away with PORTDOCS=* but I prefer to avoid globbing.
> > 
> > If you build the package with OPTIONS_UNSET=DOCS and OPTIONS_DEFAULT=
> > 3D_RENDER you'll see that the package is generated correctly (without the
> > docfiles).
> 
> I see you've jumped over and added this in r479406.  This is not how we
> do things in FreeBSD.  Either back it out or reply to my reasoning above
> with proper explanation of where and why I'm wrong.

Mmmm, you are right, this one was not required, it fell through the
cracks of all the DOXYGEN and related options that do require DOCS.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180924/97b8dcb5/attachment.sig>