svn commit: r480462 - head/devel/p5-DateTime-Format-ICal

[Jan Beich]

Po-Chuan Hsieh <sunpoet at freebsd.org> writes:

> On Sun, Sep 23, 2018 at 5:08 PM Dmitry Marakasov <amdmi3 at freebsd.org> wrote:
>
>> Author: amdmi3
>> Date: Sun Sep 23 09:08:27 2018
>> New Revision: 480462
>> URL: https://svnweb.freebsd.org/changeset/ports/480462
>>
>> Log:
>>   - Add LICENSE
>>   - Fix depends
>>
>
> I did not see any dependency change in this commit.

Before this commit BUILD_DEPENDS had lang/perl5* listed more than once. ;)

> According to mat's commit (r474242), the original one is preferred.

Porter's Handbook recommends MY_DEPENDS, not BUILD_DEPENDS=${RUN_DEPENDS}.
If you treat PH as rulebook (like portmgr often likes to do) then mat's
commit was incorrect as well.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-run_depends

Unfortunately, Porter's Handbook fails short of explaining why := is wrong.
Even if a port uses RUN_DEPENDS:=${BUILD_DEPENDS} then Mk/* can still append
to RUN_DEPENDS but anything appended to BUILD_DEPENDS doesn't propagate to
RUN_DEPENDS which is intended. Not to mention, forbidding to use := in *_DEPENDS
but not anywhere else seems odd.