svn commit: r479614 - in head/security/openssl111: . files
Cy Schubert
Cy.Schubert at cschubert.com
Wed Sep 12 20:04:07 UTC 2018
In message <20180912162033.GA51342 at FreeBSD.org>, Alexey Dokuchaev
writes:
> On Wed, Sep 12, 2018 at 04:11:11PM +0000, Bernard Spil wrote:
> > New Revision: 479614
> > URL: https://svnweb.freebsd.org/changeset/ports/479614
> >
> > Log:
> > security/openssl111: Re-add OpenSSL 1.1.1 port
> >
> > ...
> > .if ${PREFIX} == /usr
> > -IGNORE= the OpenSSL port cannot be installed over the base version
> > +IGNORE= the OpenSSL port can not be installed over the base version
>
> This change looks wrong: anything "can not be installed": you just don't
> install it.
>
> > .if ${PORT_OPTIONS:MASM}
> > -BROKEN_sparc64= option ASM generates illegal instructions
> > +BROKEN_sparc64= option ASM generates illegal instructions
>
> This change is gratuitous.
It appears it might have been a whitespace change. Whitespace changes
and other formatting changes should be separate from
substantial/functional/real code changes. When people review history
they new must parse out formatting changes from real changes. Two years
from now someone trying to figure out what the change actually was will
spend two or five times the time sifting through the diff. Future
developers will consider this POLA. I've been in this situation many
times, not just here at FreeBSD but elsewhere too. It's a PITA.
--
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
More information about the svn-ports-head
mailing list