svn commit: r479028 - head/games/yadex

Alexey Dokuchaev danfe at FreeBSD.org
Thu Sep 6 13:30:04 UTC 2018


On Wed, Sep 05, 2018 at 11:49:47PM +0200, Mathieu Arnold wrote:
> On Wed, Sep 05, 2018 at 04:31:39PM +0000, Alexey Dokuchaev wrote:
> > New Revision: 479028
> > URL: https://svnweb.freebsd.org/changeset/ports/479028
> > 
> > Log:
> >   Consummate conversion to option helpers (should've been part of r479022).
> > 
> > Modified: head/games/yadex/Makefile
> > @@ -37,17 +37,10 @@ PATCH_SUFFIX=	.diff
> >  PATCHFILES=	${PATCH_PREFIX}_Depend${PATCH_SUFFIX}
> >  
> >  3D_RENDER_PATCHFILES=	${PATCH_PREFIX}_Render3D${PATCH_SUFFIX}
> > +3D_RENDER_PORTDOCS=	preview.html
> 
> This is missing a 3D_RENDER_IMPLIES=DOCS.

I don't think so, why?  One of the nice things about PORTDOCS that is can
(and should) be set unconditionally (independent of DOCS).  In fact, I
could have simply got away with PORTDOCS=* but I prefer to avoid globbing.

If you build the package with OPTIONS_UNSET=DOCS and OPTIONS_DEFAULT=
3D_RENDER you'll see that the package is generated correctly (without the
docfiles).

./danfe


More information about the svn-ports-head mailing list