svn commit: r478889 - in head/comms/libbtbb: . files

[Jan Beich]

"George V. Neville-Neil" <gnn at FreeBSD.org> writes:

> +PORTVERSION=	201808R1
[...]
> +GH_TAGNAME=	2018-08-R1

Try replacing both with DISTVERSION=2018-08-R1 then re-run "make makesum".

> +BUILD_DEPENDS=	python27:lang/python27 \

USES=python:2.7,build or USES=python:build as it builds fine with Python 3.6.
As is the build is broken, see https://ptpb.pw/lsN0

> +		pyside-py27:devel/pyside \

pyside${PYTHON_PKGNAMESUFFIX}>0:devel/pyside@${PY_FLAVOR} but ...

> +		${PYNUMPY}

... are these actually used?

$ make clean patch BATCH=
$ fgrep -ril -e pyside -e numpy `make -V WRKSRC`

> + A Bluetooth baseband decoding library
>
> +This is a Bluetooth baseband decoding library.

Better move "decoding" to COMMENT then rephrase the rest to be less tautological.

> +bin/btaptap

$ echo DEVELOPER=1 >>${__MAKE_CONF:-/etc/make.conf}
$ make stage-qa
[...]
Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/btaptap'

> +lib/libbtbb.so
> +lib/libbtbb.so.1
> +lib/libbtbb.so.1.0

$ portlint -C
WARN: pkg-plist: [3]: installing shared libraries, please define USE_LDCONFIG as appropriate
WARN: pkg-plist: [4]: installing shared libraries, please define USE_LDCONFIG as appropriate
0 fatal errors and 2 warnings found.