svn commit: r482963 - head/misc/exercism

[Mathieu Arnold]

On Thu, Oct 25, 2018 at 03:03:43PM +0200, Mateusz Piotrowski wrote:
> Hi,
> 
> On Thu, 25 Oct 2018 at 13:59, Mathieu Arnold <mat at freebsd.org> wrote:
> 
> > On Thu, Oct 25, 2018 at 09:48:16AM +0000, Mateusz Piotrowski wrote:
> > >   - Use DISTVERSION instead of PORTVERSION as suggested by the handbook.
> >
> > This should not have happened, the version did not change.
> >
> 
> Hmmm, could you please tell me more about this? I thought that
> it is just a style change because the final value of PORTVERSION
> has not changed.

Because it changes nothing, and adds useless churn to the repository.

> 
> > >   - Move GH_TUPLE out of the USE* section.
> >
> > This is wrong, see:
> >
> > https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-uses.html
> 
> 
> Thank you for pointing this out.
> https://reviews.freebsd.org/D17699
> 
> Thanks, Mathieu!
> Mateusz

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20181025/f794c3c6/attachment.sig>