svn commit: r470615 - head

[Mathieu Arnold]

On Sat, May 26, 2018 at 02:36:51PM +0000, Gerald Pfeifer wrote:
> On Tue, 22 May 2018, Mathieu Arnold wrote:
> > New Revision: 470615
> > URL: https://svnweb.freebsd.org/changeset/ports/470615
> > 
> > Log:
> >   Don't tell people to use @${FLAVOR} in that case, it's bad practice.
> 
> I'm picking this as one example of various I've seen (from various
> committers, not meaning to single you out, Mathieu):
> 
> When going through a commit history at a later point to look for
> something specific, understand the evolution of code, or to simply
> better understand a commit, good commit messages are paramount.
> 
> The above, and unfortunately many others, do not really help much.
> 
> (What is "this case"?  Why is it bad practice? ...)

I thought I had written a verbose commit message, I usually do.

They do not have the same purpose, the idea is that:
- FLAVOR is the flavor of the current port, it only has a purpose
  locally in the port, it can be used to change the port behavior, like
  turning features on or off or whatever.
- PY_FLAVOR is the current Python flavor is the current PHP flavor, or
  any other *_FLAVOR framework defined variable, it can be influenced by
  the local FLAVOR, so that they match, but it they may not be related
  at all.  Its purpose is to be consistent when requiring dependencies,
  to make sure the port gets the correct flavor for what it needs.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180526/ad786033/attachment.sig>