svn commit: r465725 - head/lang/myrddin

[Ed Maste]

On 27 March 2018 at 16:21, Ed Maste <emaste at freebsd.org> wrote:
> On 27 March 2018 at 13:45, Tobias Kortkamp <tobik at freebsd.org> wrote:
>> Author: tobik
>> Date: Tue Mar 27 17:45:30 2018
>> New Revision: 465725
>> URL: https://svnweb.freebsd.org/changeset/ports/465725
>>
>> Log:
>>   lang/myrddin: Fix build when ld is ld.lld
>>
>>   ld: error: <internal>: section sh_addralign is not a power of 2
>>
>>   Myrddin's build system directly calls ld so LLD_UNSAFE can't work
>>   here.  Workaround the issue by adding a binary alias to ld.bfd to fix
>>   the build for now.
>
> Thanks - I wasn't aware of BINARY_ALIAS before. Also, thanks for
> adding LLD_UNSAFE in the comment so that it can be found along with
> the other lld-related failures in the future, with "grep -r
> LLD_UNSAFE".
>
> What would you think about setting BINARY_ALIAS=ld=ld.bfd
> automatically, under LLD_UNSAFE?

Antoine raised an important point in reply to my application of
BINARY_ALIAS to devel/pdcurses in r465755: arm64 has no ld.bfd by
default, and LLD_UNSAFE automatically handles using binutils from
ports for this case. So we need LLD_UNSAFE in addition to
BINARY_ALIAS.