svn commit: r461746 - head/security/ca_root_nss

[Tijl Coosemans]

On Fri, 16 Feb 2018 09:42:15 -0600 Mark Felder <feld at FreeBSD.org> wrote:
> On Wed, Feb 14, 2018, at 07:18, Tijl Coosemans wrote:
>> On Tue, 13 Feb 2018 20:45:39 +0000 (UTC) Mark Felder <feld at FreeBSD.org> wrote:
>>> Modified: head/security/ca_root_nss/pkg-plist
>>> ==============================================================================
>>> --- head/security/ca_root_nss/pkg-plist	Tue Feb 13 20:25:50 2018	(r461745)
>>> +++ head/security/ca_root_nss/pkg-plist	Tue Feb 13 20:45:38 2018	(r461746)
>>> @@ -3,3 +3,4 @@
>>>  @sample openssl/cert.pem.sample
>>>  %%ETCSYMLINK%%/etc/ssl/cert.pem
>>>  %%ETCSYMLINK%%@dir /etc/ssl
>>> + at postexec [ -x %%LOCALBASE%%/bin/cert-sync ] && %%LOCALBASE%%/bin/cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt
>> 
>> This command returns an error if the executable doesn't exist.  You
>> should invert the logic:
>> 
>> @postexec [ ! -x %%LOCALBASE%%/bin/cert-sync ] || %%LOCALBASE%%/bin/
>> cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt
> 
> What did the error look like? I wasn't seeing anything in my testport
> runs. I intentionally reversed the logic from the original submitter for
> readability and now feel like a fool.  :-)

Installing ca_root_nss-3.35_1...
pkg-static: POST-INSTALL script failed

Logically, "condition && command" is a conjunction (returns true if both
sides are true) while "!condition || command" is an implication like "if
condition then command".  If-then may be more readable though.

I changed -x to -e because I think it's informative to report an error if
the command exists but isn't executable.