svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files

[Mathieu Arnold]

On Wed, Apr 18, 2018 at 05:49:52PM +0000, Jason E. Hale wrote:
> On Wed, Apr 18, 2018 at 7:10 AM, Mathieu Arnold <mat at freebsd.org> wrote:
> > On Wed, Apr 18, 2018 at 10:21:16AM +0200, Adriaan de Groot wrote:
> >> On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote:
> >> > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote:
> >> > > Log:
> >> > >   - Update audio/liblastfm to 1.0.9-5-g4433165 [1]
> >> > >   - Add audio/liblastfm-qt5 slave port which provides a Qt 5 interface [1]
> >> >
> >> > Why not add flavors instead of a slave port?
> >>
> >>
> >> In an existing review https://reviews.freebsd.org/D14660 you (Mat) say of a
> >> different port
> >>
> >> """We currently do not accept flavors that add new packages though, so this
> >> change will be able to go in when ports-mgmt/poudriere is updated to 3.3."""
> >>
> >> That would preclude flavorizing liblastfm, wouldn't it? There are a lot of Qt4/
> >> Qt5 ports that could be flavorized and/or swept together like that.
> >
> > Mmmm, that sentence is not true any more, 3.3 was supposed to be the
> > first release to have the 32k packages limit fix, but as it was taking a
> > bit more time to get there, to the fix was backported to the 3.2 branch
> > and is in 3.2.6.  So, flavorizing is possible now. (Still requires
> > portmgr approval.)
> >
> >
> 
> I did submit a review for this (https://reviews.freebsd.org/D14667) a
> month ago and you rejected it, so I decided to move forward. Poudriere
> still has a bug in it where it is flavorizing the WRKDIR of the
> math/fftw3 dependency, however, which causes the build to fail without
> that ugly hack I put in. The port builds fine outside of poudriere
> without the hack. I did set up the port to be easily converted to
> FLAVORS, but maybe that bug should be fixed first before I re-attempt?

So you completely missed the point about why I rejected the review in
the first place.  It was so that no new packages would get there until
the 32k poudriere bug was solved in a release.  Adding a slave port also
add a new package.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180418/2c61c31e/attachment.sig>