svn commit: r467478 - in head: devel/p5-subversion devel/py-subversion devel/ruby-subversion devel/subversion devel/subversion/files java/java-subversion www/mod_dav_svn

[Adriaan de Groot]

Hi Lev,

On Monday, April 16, 2018 7:53:03 AM EDT Lev A. Serebryakov wrote:
> Modified: head/devel/p5-subversion/Makefile
> ============================================================================
> == --- head/devel/p5-subversion/Makefile   Mon Apr 16 11:18:24 2018       
> (r467477) +++ head/devel/p5-subversion/Makefile   Mon Apr 16 11:53:03 2018 
>       (r467478) @@ -2,7 +2,7 @@
>  # $FreeBSD$
> 
>  PKGNAMEPREFIX= p5-
> -PORTREVISION=  2
> +PORTREVISION=  0

It's a bit unusual to leave PORTREVISION in the Makefile when it's 0, isn't 
it? It doesn't really reduce churn, either, in the line-based diffs subversion 
supports.

>  MAINTAINER=    lev at FreeBSD.org
>  COMMENT=       Perl bindings for Version control system
> @@ -32,6 +32,9 @@ CONFIGURE_ARGS+=      --without-gnome-keyring \
> 
>  ALL_TARGET=    swig-pl-lib swig-pl
>  INSTALL_TARGET=        install-swig-pl
> +
> +#CPPFLAGS+=    -I${LOCALBASE}/lib/perl5/${PERL_VER}/${PERL_ARCH}/CORE \
> +#              -Isubversion/bindings/swig/proxy

It's also unusual to leave commented out bits-n-bobs from previous versions 
around; that's what subversion is for :)

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180416/0da78d3f/attachment.sig>