svn commit: r467193 - in head/www/gitlab: . files

[Joseph Mingrone]

Sunpoet Po-Chuan Hsieh <sunpoet at freebsd.org> writes:

> On Fri, Apr 13, 2018 at 9:35 PM, Joseph Mingrone <jrm at freebsd.org> wrote:

>> Matthias Fechner <idefix at fechner.net> writes:
>> > Dear sunpoet,

>> > Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh:
>> >> Log:
>> >>   Fix Gemfile for rubygem-default_value_for 3.1.0 update

>> >>   - Bump PORTREVISION for package change

>> >> Modified:
>> >>   head/www/gitlab/Makefile
>> >>   head/www/gitlab/files/patch-Gemfile
>> > I really enjoy your work and it is totally fine for me, if you upgrade a
>> > gem that you copy the old one and make sure that gitlab uses the old.
>> > (like you did with r467106, thanks a lot for this!)

>> > But please do not start to patch the Gemfile!
>> > This will break gitlab. Have you tested gitlab with this modification?
>> > (for sure not, I reported exactly that version of default_value_for
>> > upstream and they rolled back the change as it broke gitlab, they broke
>> > 3.0.4 and rolled back the modification with 3.0.5, now you changed
>> > gitlab to use the version that for sure will not work!)

>> > Please revert this modification and ask me (the maintainer) before you
>> > start to modify the port I maintain.
>> > Thanks a lot that you understand this.

>> > Gruß
>> > Matthias

>> I relate.  Sunpoet, I also appreciate your work, but this type of
>> breakage can be frustrating.  We need to figure out a solution.


> Hi,

> As I replied before, I'll keep the Gemfile unchanged.
> The rubygem ports will follow the version requirement in Gemfile.

> In fact, I stored the Gemfiles of gitlab, mastodon and vagrant in a
> specific directory.
> When I update a rubygem port, I check the dependent ports to see if they
> accepts the newer version.

> Regards,
> sunpoet

Thank you.  For the past while Gem updates have been smooth for net-im/mastodon.

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 962 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20180414/fc7a4269/attachment.sig>