svn commit: r466297 - head/benchmarks/sysbench

[Alexey Dokuchaev]

On Tue, Apr 03, 2018 at 11:54:42AM +0000, Alexey Dokuchaev wrote:
> On Tue, Apr 03, 2018 at 01:43:06PM +0200, Mathieu Arnold wrote:
> > On Tue, Apr 03, 2018 at 09:46:25AM +0000, Sunpoet Po-Chuan Hsieh wrote:
> > > New Revision: 466297
> > > URL: https://svnweb.freebsd.org/changeset/ports/466297
> > > 
> > > Log:
> > >   Simplify BUILD_DEPENDS: use lightweight vim-console instead of vim
> > >   
> > >   PR:		226847
> > >   Submitted by:	lwhsu
> > 
> > Great, so anyone who already has vim installed and wants to pkg install
> > this will not be able to. :-(
> 
> Shouldn't it not affect packages due to being BUILD_DEPENDS?  But even
> more importantly, maintainers really should start reading changelogs
> for the software they maintain:
> 
>   $ make patch
>   $ grep -R xxd work/sysbench-1.0.13/
>   work/sysbench-1.0.13/ChangeLog:     * remove build dependency on xxd (and vim-minimal package)

So, are we still enjoying needless BUILD_DEPENDS, or ChangeLog and grep(1)
are both wrong (lwhsu@ CC'ed)?

./danfe