svn commit: r451116 - in head/lang/sagittarius-scheme: . files

[Ashish SHUKLA]

On 10/03/2017 15:35, Jan Beich wrote:
> Ashish SHUKLA <ashish at FreeBSD.org> writes:
> 
>> Author: ashish
>> Date: Tue Oct  3 08:26:06 2017
>> New Revision: 451116
>> URL: https://svnweb.freebsd.org/changeset/ports/451116
>>
>> Log:
>>   - Update to 0.8.7
>>   - Add SIMD option (off by default) to control compilation with SIMD
>>     flags
>>   - Add program to generate cpuinfo required for SIMD support detection
> [...]
>> ++   ELSEIF(CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
>> ++     EXEC_PROGRAM(%%CPUID%% OUTPUT_VARIABLE CPUINFO)
>> ++
>> ++     STRING(REGEX REPLACE "^.*,(SSE2).*$" "\\1" SSE_THERE ${CPUINFO})
>> ++     STRING(COMPARE EQUAL "SSE2" "${SSE_THERE}" SSE2_TRUE)
>> ++     IF (SSE2_TRUE)
>> ++       set(SSE2_FOUND true CACHE BOOL "SSE2 available on host")
>> ++     ELSE (SSE2_TRUE)
>> ++       set(SSE2_FOUND false CACHE BOOL "SSE2 available on host")
>> ++     ENDIF (SSE2_TRUE)
> [...]
>>     IF (USE_SSE)
>>      IF (SSE2_FOUND)
>> 	SET(CMAKE_C_FLAGS "-msse2 ${CMAKE_C_FLAGS}")
>> 	SET(CMAKE_CXX_FLAGS "-msse2 ${CMAKE_CXX_FLAGS}")
>>       ENDIF()
> 
> Given the lack of __SSE*__ guards in the source -m* flags look like a
> cargo cult optimization or a verbose way to say CFLAGS += -march=native.
> For one, users with CPUTYPE set via make.conf already have -march= which
> enables -m* flags supported by the specific CPU.
> 

Indeed, although I'm here just trying to fix, what upstream author was
expecting.

Thanks!
-- 
Ashish SHUKLA  | GPG: F682 CDCC 39DC 0FEA E116  20B6 C746 CFA9 E74F A4B0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20171006/3598fe90/attachment.sig>