svn commit: r455173 - in head: multimedia/ffmpeg multimedia/libass net/asterisk13 net/freerdp x11/rxvt-unicode

[Mark Millard]

On 2017-Nov-29, at 11:35 PM, Jan Beich <jbeich at FreeBSD.org> wrote:

> Mark Linimon <linimon at FreeBSD.org> writes:
> 
>> Author: linimon
>> Date: Thu Nov 30 07:02:49 2017
>> New Revision: 455173
>> URL: https://svnweb.freebsd.org/changeset/ports/455173
>> 
>> Log:
>>  For ports that set particular flags/options for armv6, also set them
>>  for armv7.
> [...]
>> Modified: head/multimedia/ffmpeg/Makefile
>> ==============================================================================
>> --- head/multimedia/ffmpeg/Makefile	Thu Nov 30 07:01:14 2017	(r455172)
>> +++ head/multimedia/ffmpeg/Makefile	Thu Nov 30 07:02:49 2017	(r455173)
>> @@ -54,6 +54,7 @@ OPTIONS_GROUP_LICENSE=	GPL3 NONFREE
>> 
>> OPTIONS_DEFINE_amd64=	MMX SSE
>> OPTIONS_DEFINE_armv6=	VFP NEON
>> +OPTIONS_DEFINE_armv7=	VFP NEON
> 
> Are you sure about disabling VFP and NEON by default? If so bump PORTREVISION.
> Otherwise, back this part out.
> 
> $ cc -v
> FreeBSD clang version 5.0.0 (tags/RELEASE_500/final 312559) (based on LLVM 5.0.0svn)
> Target: armv7-unknown-freebsd12.0-gnueabihf
> Thread model: posix
> InstalledDir: /nxb-bin/usr/bin
> 
> $ cc -dM -E -</dev/null 2>&1 | fgrep -i -e vfp -e neon
> #define __ARM_NEON 1
> #define __ARM_NEON_FP 0x4
> #define __ARM_NEON__ 1
> #define __ARM_PCS_VFP 1
> #define __ARM_VFPV3__ 1
> #define __VFP_FP__ 1
> 
>> +CONFIGURE_ARGS_armv7=		--disable-fast-unaligned
> 
> Can anyone on arm@ list confirm bug 200609 affects armv7 as well?
> I'd prefer to avoid the pessimization otherwise.

I'm unsure of the detailed current status but
there was a time when the save/restore of VFP/NEON
was not working across context switches of at
least some kinds. Bugzilla 217611 was for signal
delivery (fixed) but I'm not sure that was all
there was to it: There are some notes there about
struct fpreg as well.

Also did head -r324660 (and prior work) get its MFC?
There is no commit-hook entry for the MFC listed
in bugzilla 217611.


===
Mark Millard
markmi at dsl-only.net