svn commit: r435576 - head/devel/pkgconf

[Mathieu Arnold]

Le 07/03/2017 à 02:03, Dag-Erling Smørgrav a écrit :
> Author: des
> Date: Tue Mar  7 01:03:19 2017
> New Revision: 435576
> URL: https://svnweb.freebsd.org/changeset/ports/435576
>
> Log:
>   Change the search path to include ${PREFIX}/lib/pkgconfig ahead of the
>   usual ${PREFIX}/libdata/pkgconfig and /usr/libdata/pkgconfig.  This
>   renders 82.6% of Mk/Uses/pathfix.mk obsolete.


I am wondering how you came to commit this without getting approval from portmgr.

We always had a policy about putting the pkg-config files in libdata/pkgconfig and not in lib.

And you just changed that 20 years old policy without even a discussion about the repercussions it would have.

For example, there is a lot of software around that knows that FreeBSD has the .pc files in libdata/pkgconfig, and now, with this, you are paving the way to moving things in lib, and I figure we are going to need a USES=pathunfix to put things where you changed it.


So, before changing this policy, I am going to ask you, as portmgr, to please back the change out.


Once this is done, and if you feel strongly about it, we can always discuss changing the policy, and then test that it will not break things, and then, maybe change the policy. But only after all those steps.

Regards,

>   Reviewed by:	bapt
>   Approved by:	bapt
>
> Modified:
>   head/devel/pkgconf/Makefile
>
> Modified: head/devel/pkgconf/Makefile
> ==============================================================================
> --- head/devel/pkgconf/Makefile	Tue Mar  7 00:06:43 2017	(r435575)
> +++ head/devel/pkgconf/Makefile	Tue Mar  7 01:03:19 2017	(r435576)
> @@ -2,6 +2,7 @@
>  
>  PORTNAME=	pkgconf
>  PORTVERSION=	1.3.0
> +PORTREVISION=	1
>  CATEGORIES=	devel
>  MASTER_SITES=	https://distfiles.dereferenced.org/pkgconf/ \
>  		http://files.etoilebsd.net/pkgconf/
> @@ -16,7 +17,7 @@ GNU_CONFIGURE=	yes
>  INSTALL_TARGET=	install-strip
>  USE_LDCONFIG=	yes
>  TEST_TARGET=	check
> -CONFIGURE_ARGS=	--with-pkg-config-dir=${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \
> +CONFIGURE_ARGS=	--with-pkg-config-dir=${PREFIX}/lib/pkgconfig:${PREFIX}/libdata/pkgconfig:/usr/libdata/pkgconfig \
>  		--with-system-libdir=/usr/lib \
>  		--with-system-includedir=/usr/include
>  MAKE_ARGS=	MANDIR="${MAN1PREFIX}/man/man1"
>
>


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20170307/0dc25d90/attachment-0001.sig>