svn commit: r432561 - head/lang/php71

[Torsten Zuehlsdorff]

On 29.01.2017 19:55, John Marino wrote:
>> On 27.01.2017 19:52, John Marino wrote:
>>> Author: marino
>>> Date: Fri Jan 27 18:52:24 2017
>>> New Revision: 432561
>>> URL: https://svnweb.freebsd.org/changeset/ports/432561
>>>
>>> Log:
>>>   lang/php71: Bring DTRACE exclude for DF from lang/php70
>>>
>>>   Maybe this would have been caught with SVN copy?  Oh well.
>>>
>>>   Approved by:    just-fix-it
>>
>> Its funny how "just-fix-it" often translate in "just-broke-it" - see
>> r432567.
>>
>> But beside that back to being serious: why did nobody suggest a fix? If
>> repo-copy is this needed, we can do it right now?
>> svn rm lang/php71 && svn cp -r432321 lang/php70 lang/php71 && some files
>> copied would be all.
>> I took mat into CC because i want to know if something speaks against it
>> or if just nobody thought about it.
>>
>> Also fun note: with an svn copy the DTRACE option wouldn't be included
>> too. I finished the patch 2 month ago, long before DTRACE was
>> introduced. So it wouldn't be there.
>
> Which would be an error of process.
> - svn cp php70
> - overwrite with your working copy
> - view with svn diff.  The new additions in the last 2 months would be
> apparent.  Thus the 3rd step wasn't done.

I did exactly this. 2 months ago there was no DTRACE in php70. So 
copying the working-copy of php71 over the repo-copy would have not 
included the DTRACE option. Therefore the repo-copy wouldn't have had 
helped.

> You misunderstood r432567.
> That wasn't to correct my commit.
> That was to add the second missing item, DTRACE for aarch.
>
>> I just noted in this 2 month how hard it is to find somebody for review
>> and second how hard it is to get such a patch reviewed. First the
>> review.freebsd.org didn't work for me because it contains a bug with
>> umlaut for years. And second a repocopy could not be displayed.
>
> Yes, the diff would have been displayed.
> That's the benefit of repocopy.

Maybe i wasn't clear enough: the repo-copy could not displayed in 
review.freebsd.org. If you say: its possible. Okay, than its just the 
umlaut-bug preventing the display of my patch.

But - no, you are not right this time. Doing a repo-copy without 
changing the copy will cause a svn diff to just list the files. The diff 
didn't even contain the revision copied from. To bring a path like this 
into the review tool you need at least the --show-copies-as-adds param, 
which defeats the purpose of a repo-copy in review.

Greetings,
Torsten