svn commit: r457491 - in head/textproc/sxml: . files

[Alexey Dokuchaev]

On Fri, Dec 29, 2017 at 03:30:13AM +0000, Wen Heping wrote:
> New Revision: 457491
> URL: https://svnweb.freebsd.org/changeset/ports/457491
> 
> Log:
>   - Update to 1.0.7
>   - Update LICENSE
> 
> Modified: head/textproc/sxml/Makefile
> ...
> @@ -2,23 +2,21 @@
>  
> -USES=		tar:bzip2
>  GNU_CONFIGURE=	yes
>  USE_LDCONFIG=	yes
> +USES=		tar:bzip2

This change (USES move) is both gratuitous and wrong.

> -MAKE_JOBS_UNSAFE=	yes

So it builds fine with -jX now?  What was the reason for failures before?
Commit message tells nothing about this and how was it fixed (if it was).

> +do-test:	build
> +	cd ${BUILD_WRKSRC}/examples && ${MAKE} all

${MAKE_CMD}, not ${MAKE}.  Also, consider using -C instead of `cd'.  On
a related note, I don't exactly see how building of examples performs
any sort of tests; it looks like nothing is being run or checked.

> Modified: head/textproc/sxml/pkg-descr
> ...
> @@ -1,4 +1,5 @@
> -SXML is a skimpy XML parsing and grafting C library that you can use
> -to read and write XML-like configuration file for your application.
> +SXML is a skimpy XML parsing and grafting C library that you can use to read
> +and write XML-like configuration file for your application.
>  
> +Author:	Kouichi ABE (WALL) <kouichi at MysticWALL.COM>

This line was added wrongly; few years ago ports were sweeped to remove
direct author attribution, and now you're adding them back.  Please don't.

./danfe