svn commit: r456640 - in head/audio/volumeicon: . files

[Alexey Dokuchaev]

On Mon, Dec 18, 2017 at 04:25:32PM +0000, Lars Engels wrote:
> New Revision: 456640
> URL: https://svnweb.freebsd.org/changeset/ports/456640
> 
> Log:
>   audio/volumeicon:
>   
>   - Add OSS v3 backend [1]
>   - Fix mixer channel selection in Preferences/Channels
>   - Bump PORTREVISION
>   
> [...]
> Added: head/audio/volumeicon/files/patch-configure.ac
> ...
> @@ -0,0 +1,20 @@
> +--- configure.ac.orig	2015-03-02 23:54:36.000000000 +0100
> ++++ configure.ac	2017-12-18 17:23:45.215876000 +0100

Hmm, any reason why patches were not generated with ``make makepatch''?

> Modified: head/audio/volumeicon/files/patch-data_gui_preferences.ui
> @@ -1,5 +1,5 @@
> ---- data/gui/preferences.ui.orig	2017-12-12 18:43:30 UTC
> -+++ data/gui/preferences.ui
> +--- data/gui/preferences.ui.orig	2015-03-02 23:54:36.000000000 +0100
> ++++ data/gui/preferences.ui	2017-12-18 17:23:45.219716000 +0100
>  @@ -197,7 +197,7 @@
>                                 <object class="GtkLabel" id="label5">
>                                   <property name="visible">True</property>

The contents of the patch did not change, only the header.  Why wasn't it
excluded from the commit batch?

> +--- src/Makefile.am.orig	2015-03-02 23:54:36.000000000 +0100
> ++++ src/Makefile.am	2017-12-18 17:23:45.222731000 +0100

Ditto (no ``make makepatch'' => bad timestamps).

> Added: head/audio/volumeicon/files/patch-src_oss3__backend.c
> ...
> +--- src/oss3_backend.c.orig    2017-12-18 17:23:45.225185000 +0100
> ++++ src/oss3_backend.c 2017-12-18 17:23:57.906175000 +0100
> +@@ -0,0 +1,185 @@
      ^^^^
Ouch.  New files should be put to ${FILESDIR} as is, not as a patch to a
non-existent file.  Patches are for modifying pre-existing files; creating
new ones via patch is bad practice.  This also produced convoluted diffs
with future updates.

> Modified: head/audio/volumeicon/files/patch-src_oss__backend.h
> ...
> @@ -1,5 +1,5 @@
> ---- src/oss_backend.h.orig	2015-03-02 22:54:36 UTC
> -+++ src/oss_backend.h
> +--- src/oss_backend.h.orig	2015-03-02 23:54:36.000000000 +0100
> ++++ src/oss_backend.h	2017-12-18 17:23:45.233327000 +0100
>  @@ -35,5 +35,7 @@ int oss_get_volume();
>   gboolean oss_get_mute();
>   const gchar * oss_get_channel();

Ditto: useless changes (repo churn), timestamp pessimization.

> Modified: head/audio/volumeicon/files/patch-src_volumeicon.c
> ...
> @@ -1,5 +1,5 @@
> ---- src/volumeicon.c.orig	2015-03-02 22:54:36 UTC
> -+++ src/volumeicon.c
> +--- src/volumeicon.c.orig	2015-03-02 23:54:36.000000000 +0100
> ++++ src/volumeicon.c	2017-12-18 17:23:45.237664000 +0100
>  @@ -1295,6 +1295,8 @@ int main(int argc, char * argv[])
>   	backend_get_mute = &oss_get_mute;
>   	backend_get_channel = &oss_get_channel;

Ditto.  Please review your commit batch prior to commit with "svn st"
and "svn diff".

./danfe