svn commit: r456527 - in head/databases: . postgis20 postgis21 postgis22 postgis23 postgis24

[Rodrigo Osorio]

On 12/19/17 13:38, Mathieu Arnold wrote:
> Le 18/12/2017 à 15:07, Mathieu Arnold a écrit :
>> Le 18/12/2017 à 10:15, Rodrigo Osorio a écrit :
>>> On 12/18/17 02:00, Alexey Dokuchaev wrote:
>>>> On Sun, Dec 17, 2017 at 01:25:43PM +0100, Rodrigo Osorio wrote:
>>>>> On 12/17/17 12:41, Alexey Dokuchaev wrote:
>>>>>> On Sun, Dec 17, 2017 at 11:25:14AM +0000, Rodrigo Osorio wrote:
>>>>>>> New Revision: 456527
>>>>>>> URL: https://svnweb.freebsd.org/changeset/ports/456527
>>>>>>>
>>>>>>> Log:
>>>>>>>      Add new port postgis24 for v2.4.x
>>>>>>>
>>>>>>> Added:
>>>>>>>      head/databases/postgis24/
>>>>>>>      head/databases/postgis24/Makefile   (contents, props changed)
>>>>>>>      head/databases/postgis24/distinfo   (contents, props changed)
>>>>>>>      head/databases/postgis24/pkg-descr   (contents, props changed)
>>>>>>>      head/databases/postgis24/pkg-install   (contents, props changed)
>>>>>>>      head/databases/postgis24/pkg-plist   (contents, props changed)
>>>>>> Looks like it should've been repocopied, not added as a new port.
>>>>>> Can you explain why this wasn't done?
>>>>> I don't get your question, do you see any issue regarding postgis24
>>>>> port?
>>>> I have an issue not with the port per se, but with the way it was
>>>> carried
>>>> out (added to the collection).  Please read Section 19.4* of the Ports
>>>> Committer's Guide, albeit I'm surprised that your mentor did not tell
>>>> you
>>>> about it earlier.
>>> Now I understand...
>>>
>>> To clarify my mentor instruct me about the procedure but it was a long
>>> time ago.
>>> I don't do this kind of commit so often, and this is probably my mistake.
>> Now that this is all clarified and you know what to do, please remove
>> the postgis24 port you added, and add it back using the proper procedure.
>
> Ping ?
>
>
Mathieu,

To be sure to do it once I submit the final fix as a review yesterday : 
https://reviews.freebsd.org/D13533.
I notify danfe about it but has no feedback so I will commit the changes

regards
- rodrigo